lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] MFD : add MAX77686 mfd driver
    Hi, Andi.

    These exported functions will be used in 77686 area only, so there is no
    overlap locking.

    Thanks.

    On 2012-04-30 18:17, Andi Shyti wrote:

    > Hi,
    >
    >> + mutex_lock(&max77686->iolock);
    >> + ret = i2c_smbus_read_i2c_block_data(i2c, reg, count, buf);
    >> + mutex_unlock(&max77686->iolock);
    >
    > Is it relly necessay to lock whenever you read/write from/to the
    > i2c bus? Considering also that these are exported function,
    > someone else may lock here before, so we can have a double
    > locking on the same mutex.
    >
    > Andi
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >




    \
     
     \ /
      Last update: 2012-05-02 07:41    [W:0.034 / U:0.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site