lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] net: l2tp: unlock socket lock before returning from l2tp_ip_sendmsg
From
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 02 May 2012 16:32:36 +0200

> On Wed, 2012-05-02 at 15:58 +0200, Sasha Levin wrote:
>> l2tp_ip_sendmsg could return without releasing socket lock, making it all the
>> way to userspace, and generating the following warning:
>>
>> [ 130.891594] ================================================
>> [ 130.894569] [ BUG: lock held when returning to user space! ]
>> [ 130.897257] 3.4.0-rc5-next-20120501-sasha #104 Tainted: G W
>> [ 130.900336] ------------------------------------------------
>> [ 130.902996] trinity/8384 is leaving the kernel with locks still held!
>> [ 130.906106] 1 lock held by trinity/8384:
>> [ 130.907924] #0: (sk_lock-AF_INET){+.+.+.}, at: [<ffffffff82b9503f>] l2tp_ip_sendmsg+0x2f/0x550
>>
>> Introduced by commit 2f16270 ("l2tp: Fix locking in l2tp_ip.c").
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>> ---
>
> Oh well, please read Documentation/stable_kernel_rules.txt
>
> Also, David prefers to handle stable submissions himself for net tree.
>
> Anyway :
>
> Acked-by: Eric Dumazet <edumazet@google.com>

Applied.


\
 
 \ /
  Last update: 2012-05-03 03:41    [from the cache]
©2003-2011 Jasper Spaans