lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] cifs - check S_AUTOMOUNT in revalidate
    From
    Date
    On Wed, 2012-05-02 at 13:50 -0400, Jeff Layton wrote:
    > On Wed, 02 May 2012 17:15:29 +0530
    > Suresh Jayaraman <sjayaraman@suse.com> wrote:
    >
    > > On 04/28/2012 09:03 AM, Steve French wrote:
    > > > The fix makes sense, but it is fairly recent and I haven't had a
    > > > chance to try it,
    > > > so unless a new release is imminent, I would prefer to put in the next merge
    > > > request (I have at least one more fix likely as well) next week.
    > >
    > > We need this fix for -stable as well, right? Please include
    > >
    > > Cc: stable@vger.kernel.org
    > >
    > >
    > > Suresh
    > >
    > >
    > > --
    > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
    > > the body of a message to majordomo@vger.kernel.org
    > > More majordomo info at http://vger.kernel.org/majordomo-info.html
    >
    > The stable-kernel-rules.txt file says this:
    >
    > - It must fix a real bug that bothers people (not a, "This could be a
    > problem..." type thing).
    >
    > ...and...
    >
    > - No "theoretical race condition" issues, unless an explanation of how the
    > race can be exploited is also provided.
    >
    > ...and this seems to clearly violate both of those rules. I'd say we
    > just go with putting it in 3.4 for now, and keep it in mind if someone
    > comes back later and says that it's needed.
    >

    I have to agree with Jeff.

    I just happened to notice it when trying to work out why DFS automounts
    weren't happening.

    I eventually found that the kernel in use didn't have the d_invalidate()
    patch, then realized the potential problem. It would require fairly
    heavy demand to trigger so it isn't urgent, especially since no-one has
    actually reported it.

    Another reason I should have sent this to Steve, not Linus, sorry for
    the noise Linus.

    Ian




    \
     
     \ /
      Last update: 2012-05-03 03:41    [W:0.026 / U:33.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site