lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    Subjectstaging/rtl8712: unhandled default case in SwLedOn function.
    From
    Hi kernel developers,

    In the function SwLedOn in rtl8712_led.c, we put the bLedOn = true,
    even if its a default case. may be we need to return? or BUG()?.

    the code listing is:

    if ((padapter->bSurpriseRemoved == true) ||
    (padapter->bDriverStopped == true))
    return;
    LedCfg = r8712_read8(padapter, LEDCFG);
    switch (pLed->LedPin) {
    case LED_PIN_GPIO0:
    break;
    case LED_PIN_LED0:
    /* SW control led0 on.*/
    r8712_write8(padapter, LEDCFG, LedCfg&0xf0);
    break;
    case LED_PIN_LED1:
    /* SW control led1 on.*/
    r8712_write8(padapter, LEDCFG, LedCfg&0x0f);
    break;
    default:
    break;
    }
    pLed->bLedOn = true;

    Thanks,
    Dev.


    \
     
     \ /
      Last update: 2012-05-02 22:21    [W:0.031 / U:183.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site