lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/15] perf tools: Check more combinations of PID/TID, UID and CPU switches
    Date
    From: Namhyung Kim <namhyung.kim@lge.com>

    There were some combinations of these switches that are not so
    appropriate IMHO.

    Since there are implicit priorities between them and they worked well
    anyway, but it ends up opening useless duplicated events.

    For example, 'perf stat -t <pid> -a' will open multiple events for the
    thread instead of one.

    Add explicit checks and warn user in perf_target__validate().

    Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
    Reviewed-by: David Ahern <dsahern@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1335417327-11796-7-git-send-email-namhyung.kim@lge.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/usage.c | 14 ++++++++++++++
    1 file changed, 14 insertions(+)

    diff --git a/tools/perf/util/usage.c b/tools/perf/util/usage.c
    index 0a1a885..228f0a5 100644
    --- a/tools/perf/util/usage.c
    +++ b/tools/perf/util/usage.c
    @@ -132,4 +132,18 @@ void perf_target__validate(struct perf_target *target)
    sleep(1);
    target->uid_str = NULL;
    }
    +
    + /* UID and CPU are mutually exclusive */
    + if (target->uid_str && target->cpu_list) {
    + ui__warning("UID switch overriding CPU\n");
    + sleep(1);
    + target->cpu_list = NULL;
    + }
    +
    + /* PID/UID and SYSTEM are mutually exclusive */
    + if ((target->tid || target->uid_str) && target->system_wide) {
    + ui__warning("PID/TID/UID switch overriding CPU\n");
    + sleep(1);
    + target->system_wide = false;
    + }
    }
    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-05-02 21:41    [W:0.024 / U:31.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site