Messages in this thread Patch in this message | | | Date | Wed, 2 May 2012 11:10:46 -0400 | From | Joe Korty <> | Subject | checkpatch: kstrtol fix |
| |
kstrtol is a substitute for simple_strtol() only when when second arg of simple_strtol() is NULL. For any other value the functionality of simple_strtol() cannot be implemented in terms of kstrtol.
So modify checkpatch.pl so that it prints out the following warning only if the second argument is null:
WARNING: simple_strtol is obsolete, use kstrtol instead
Signed-off-by: Joe Korty <joe.korty@ccur.com>
Index: linux/scripts/checkpatch.pl =================================================================== --- linux.orig/scripts/checkpatch.pl 2012-05-02 10:38:45.000000000 -0400 +++ linux/scripts/checkpatch.pl 2012-05-02 10:47:58.000000000 -0400 @@ -3359,8 +3359,8 @@ "consider using a completion\n" . $herecurr); } -# recommend kstrto* over simple_strto* and strict_strto* - if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) { +# recommend kstrto* over simple_strto* and strict_strto* where appropriate + if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\([^,]+,\s*NULL\s*,/) { WARN("CONSIDER_KSTRTO", "$1 is obsolete, use k$3 instead\n" . $herecurr); }
| |