lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: checkpatch: brackets around single statements fix
On Wed, May 02, 2012 at 11:10:46AM -0400, Joe Korty wrote:
> Checkpatch thinks '#else' is the same as 'else' in its check for
> this error:
>
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Joe Korty <joe.korty@ccur.com>
>
> Index: linux/scripts/checkpatch.pl
> ===================================================================
> --- linux.orig/scripts/checkpatch.pl 2012-04-17 05:00:37.000000000 -0400
> +++ linux/scripts/checkpatch.pl 2012-05-02 10:29:03.000000000 -0400
> @@ -3038,7 +3038,7 @@
> }
> }
> if (!defined $suppress_ifbraces{$linenr - 1} &&
> - $line =~ /\b(if|while|for|else)\b/) {
> + $line =~ /[^#]\b(if|while|for|else)\b/) {
> my $allowed = 0;
>
> # Check the pre-context.

Interesting. Got an example I can use to add to the test suite.

-apw


\
 
 \ /
  Last update: 2012-05-02 17:41    [W:0.038 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site