lkml.org 
[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality.
    On Wed, May 2, 2012 at 9:07 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
    > On 2 May 2012 21:59, Rob Lee <rob.lee@linaro.org> wrote:
    >>>> +             ret = cpuidle_register_device(dev);
    >>>> +             if (ret) {
    >>>> +                     pr_err("%s: Failed to register cpu %u\n",
    >>>> +                             __func__, cpu_id);
    >>>
    >>> Nit: print ret (error code) too?
    >>>
    >>
    >> I added the printing of the error code based on Sascha's suggestion in
    >> v1 of this submission.
    >>
    > But you did not print "ret" in above pr_err.
    >

    Argh, sorry, still trying to wake up I guess. Thanks.

    > Regards,
    > Shawn
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-02 16:41    [W:0.026 / U:30.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site