lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 09/54] regulator: Fix the logic to ensure new voltage setting in valid range
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Axel Lin <axel.lin@gmail.com>

    commit f55205f4d4a8823a11bb8b37ef2ecbd78fb09463 upstream.

    I think this is a typo.
    To ensure new voltage setting won't greater than desc->max,
    the equation should be desc->min + desc->step * new_val <= desc->max.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/regulator/max8997.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/regulator/max8997.c
    +++ b/drivers/regulator/max8997.c
    @@ -688,7 +688,7 @@ static int max8997_set_voltage_buck(stru
    }

    new_val++;
    - } while (desc->min + desc->step + new_val <= desc->max);
    + } while (desc->min + desc->step * new_val <= desc->max);

    new_idx = tmp_idx;
    new_val = tmp_val;



    \
     
     \ /
      Last update: 2012-05-19 02:21    [W:3.979 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site