lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 15/54] sky2: propogate rx hash when packet is copied
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: stephen hemminger <shemminger@vyatta.com>

    [ Upstream commit 3f42941b5d1d13542b1a755a9e4f633aa72e4d3e ]

    When a small packet is received, the driver copies it to a new skb to allow
    reusing the full size Rx buffer. The copy was propogating the checksum offload
    but not the receive hash information. The bug is impact was mostly harmless
    and therefore not observed until reviewing this area of code.

    Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/sky2.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/sky2.c
    +++ b/drivers/net/sky2.c
    @@ -2344,8 +2344,11 @@ static struct sk_buff *receive_copy(stru
    skb_copy_from_linear_data(re->skb, skb->data, length);
    skb->ip_summed = re->skb->ip_summed;
    skb->csum = re->skb->csum;
    + skb->rxhash = re->skb->rxhash;
    +
    pci_dma_sync_single_for_device(sky2->hw->pdev, re->data_addr,
    length, PCI_DMA_FROMDEVICE);
    + re->skb->rxhash = 0;
    re->skb->ip_summed = CHECKSUM_NONE;
    skb_put(skb, length);
    }



    \
     
     \ /
      Last update: 2012-05-19 02:21    [W:4.064 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site