lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 10/54] ARM: orion5x: Fix GPIO enable bits for MPP9
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    commit 48d99f47a81a66bdd61a348c7fe8df5a7afdf5f3 upstream.

    Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
    mpp code to use common orion platform mpp.') seems to have accidentally
    inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
    which uses MPP9 as a GPIO LED device, this results in the error:

    [ 12.711476] leds-gpio: probe of leds-gpio failed with error -22

    Reported-by: Henry von Tresckow <hvontres@gmail.com>
    References: http://bugs.debian.org/667446
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Tested-by: Hans Henry von Tresckow <hvontres@gmail.com>
    Signed-off-by: Jason Cooper <jason@lakedaemon.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/mach-orion5x/mpp.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/arm/mach-orion5x/mpp.h
    +++ b/arch/arm/mach-orion5x/mpp.h
    @@ -65,8 +65,8 @@
    #define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)

    #define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
    -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
    -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
    +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
    +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)

    #define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
    #define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)



    \
     
     \ /
      Last update: 2012-05-19 02:01    [W:4.659 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site