lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 44/54] ext3: Fix error handling on inode bitmap corruption
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit 1415dd8705394399d59a3df1ab48d149e1e41e77 upstream.

    When insert_inode_locked() fails in ext3_new_inode() it most likely
    means inode bitmap got corrupted and we allocated again inode which
    is already in use. Also doing unlock_new_inode() during error recovery
    is wrong since inode does not have I_NEW set. Fix the problem by jumping
    to fail: (instead of fail_drop:) which declares filesystem error and
    does not call unlock_new_inode().

    Reviewed-by: Eric Sandeen <sandeen@redhat.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext3/ialloc.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/fs/ext3/ialloc.c
    +++ b/fs/ext3/ialloc.c
    @@ -561,8 +561,12 @@ got:
    if (IS_DIRSYNC(inode))
    handle->h_sync = 1;
    if (insert_inode_locked(inode) < 0) {
    - err = -EINVAL;
    - goto fail_drop;
    + /*
    + * Likely a bitmap corruption causing inode to be allocated
    + * twice.
    + */
    + err = -EIO;
    + goto fail;
    }
    spin_lock(&sbi->s_next_gen_lock);
    inode->i_generation = sbi->s_next_generation++;



    \
     
     \ /
      Last update: 2012-05-19 02:01    [W:0.027 / U:96.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site