lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/13] block: Kill bi_destructor
    On Fri, May 18, 2012 at 09:21:42AM -0700, Tejun Heo wrote:
    > Hello,
    >
    > > @@ -417,8 +409,11 @@ void bio_put(struct bio *bio)
    > >
    > > if (bio->bi_pool)
    > > bio_free(bio, bio->bi_pool);
    > > - else
    > > - bio->bi_destructor(bio);
    > > + else {
    > > + if (bio_integrity(bio))
    > > + bio_integrity_free(bio, fs_bio_set);
    > > + kfree(bio);
    >
    > if {
    > } else {
    > }
    >
    > And wouldn't it be better to make bio_free() handle kfreeing too?

    That'd kind of change the semantics of bio_free() - but I suppose it'd
    make sense.

    I'm not terribly happy with how the bio integrity data belongs to
    fs_bio_set for kmalloced bios. Maybe I'll change that at some point.


    \
     
     \ /
      Last update: 2012-05-19 01:01    [W:0.028 / U:29.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site