lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1]USB:storage:fixed space at the start of a line issues.
    On Sat, May 19, 2012 at 12:48:35AM +0530, Jeffrin Jose wrote:
    > Fixed space at the start of a line issues found
    > by checkpatch.pl tool in drivers/usb/storage/usual-tables.c
    >
    > Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

    Your subject is better, but now you forgot the spaces after the ':'
    characters, what happened to them?

    > ---
    > drivers/usb/storage/usual-tables.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/usb/storage/usual-tables.c b/drivers/usb/storage/usual-tables.c
    > index b969279..f2301ee 100644
    > --- a/drivers/usb/storage/usual-tables.c
    > +++ b/drivers/usb/storage/usual-tables.c
    > @@ -34,17 +34,17 @@
    > vendorName, productName, useProtocol, useTransport, \
    > initFunction, flags) \
    > { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
    > - .driver_info = (flags)|(USB_US_TYPE_STOR<<24) }
    > +.driver_info = (flags)|(USB_US_TYPE_STOR<<24) }

    That's dumb, and should not be changed, sorry.

    checkpatch isn't always correct, please think when using it.

    greg k-h


    \
     
     \ /
      Last update: 2012-05-18 21:41    [W:0.026 / U:93.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site