lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/13] block: Add bio_reset()
    Hello,

    On Thu, May 17, 2012 at 10:59:53PM -0400, koverstreet@google.com wrote:
    > From: Kent Overstreet <koverstreet@google.com>
    >
    > Reusing bios is something that's been highly frowned upon in the past,
    > but driver code keeps doing it anyways. If it's going to happen anyways,
    > we should provide a generic method.
    >
    > This'll help with getting rid of bi_destructor.

    It would be nice to explain a bit why this helps bi_destructor
    removal.

    > +#define BIO_RESET_OFFSET offsetof(struct bio, bi_max_vecs)

    Maybe better named BIO_RESET_BYTES? As offset tends to indicate the
    start of a region.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-05-18 18:41    [W:0.024 / U:0.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site