lkml.org 
[lkml]   [2012]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/apic] x86/apic: Use symbolic APIC_EOI_ACK
    Commit-ID:  4ebcc243901c48ee3baba6bdf179c7315fa8806f
    Gitweb: http://git.kernel.org/tip/4ebcc243901c48ee3baba6bdf179c7315fa8806f
    Author: Michael S. Tsirkin <mst@redhat.com>
    AuthorDate: Wed, 16 May 2012 19:03:44 +0300
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Fri, 18 May 2012 09:46:08 +0200

    x86/apic: Use symbolic APIC_EOI_ACK

    Use the symbol instead of hard-coded numbers,
    now that the reason for the value is documented
    where the constant is defined we don't need to
    duplicate this explanation in code.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Cc: Avi Kivity <avi@redhat.com>
    Cc: Marcelo Tosatti <mtosatti@redhat.com>
    Cc: gleb@redhat.com
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Link: http://lkml.kernel.org/r/ecbe4c79d69c172378e47e5a587ff5cd10293c9f.1337184153.git.mst@redhat.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    arch/x86/include/asm/apic.h | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
    index d854101..a09e9ab 100644
    --- a/arch/x86/include/asm/apic.h
    +++ b/arch/x86/include/asm/apic.h
    @@ -463,9 +463,7 @@ static inline void ack_APIC_irq(void)
    * ack_APIC_irq() actually gets compiled as a single instruction
    * ... yummie.
    */
    -
    - /* Docs say use 0 for future compatibility */
    - apic_write(APIC_EOI, 0);
    + apic_write(APIC_EOI, APIC_EOI_ACK);
    }

    static inline unsigned default_get_apic_id(unsigned long x)

    \
     
     \ /
      Last update: 2012-05-18 14:01    [W:0.029 / U:91.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site