lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 3/3] gpio: TS-5500 GPIO support
From
Date
On Thu, 2012-05-17 at 15:06 -0600, Grant Likely wrote:
> > arch/x86/include/asm/ts5500.h | 62 ++++++++
>
> Why the separate header file? What will use these defines? I
> normally expect driver-specific defines to be in the driver .c file
> directly; particularly for things like gpio drivers which should be a
> generic interface that doesn't need to export symbols.

Should an intermediate driver directly use values for GPIOs instead of
these symbols? For example, how should a temperature sensor plugged on
this platform refer to inputs and outputs?

Thanks,
Vivien



\
 
 \ /
  Last update: 2012-05-18 00:21    [from the cache]
©2003-2011 Jasper Spaans