lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] cred: use correct cred accessor with regards to rcu read lock
    Date
    Commit "userns: Convert setting and getting uid and gid system calls to use
    kuid and kgid has modified the accessors in wait_task_continued() and
    wait_task_stopped() to use __task_cred() instead of task_uid().

    __task_cred() assumes that we're inside a rcu read lock, which is untrue
    for these two functions.

    Modify it to use task_uid() instead.

    Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
    ---
    kernel/exit.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/exit.c b/kernel/exit.c
    index 6818cbb..7e54635 100644
    --- a/kernel/exit.c
    +++ b/kernel/exit.c
    @@ -1455,7 +1455,7 @@ static int wait_task_stopped(struct wait_opts *wo,
    if (!unlikely(wo->wo_flags & WNOWAIT))
    *p_code = 0;

    - uid = from_kuid_munged(current_user_ns(), __task_cred(p)->uid);
    + uid = from_kuid_munged(current_user_ns(), task_uid(p));
    unlock_sig:
    spin_unlock_irq(&p->sighand->siglock);
    if (!exit_code)
    @@ -1528,7 +1528,7 @@ static int wait_task_continued(struct wait_opts *wo, struct task_struct *p)
    }
    if (!unlikely(wo->wo_flags & WNOWAIT))
    p->signal->flags &= ~SIGNAL_STOP_CONTINUED;
    - uid = from_kuid_munged(current_user_ns(), __task_cred(p)->uid);
    + uid = from_kuid_munged(current_user_ns(), task_uid(p));
    spin_unlock_irq(&p->sighand->siglock);

    pid = task_pid_vnr(p);
    --
    1.7.8.6


    \
     
     \ /
      Last update: 2012-05-18 00:01    [W:0.024 / U:159.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site