lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] perf script: Add general python handler to process non-tracepoint events
    Em Wed, May 16, 2012 at 08:59:13PM +0800, Feng Tang escreveu:
    > This patch just follows Robert Richter's idea and the commit 37a058ea0
    > "perf script: Add generic perl handler to process events"
    > to similarly add a python handler for general events other than tracepoints.
    >
    > For non-tracepoint events, this patch will try to find a function named
    > "process_general_event" in the python script, and pass the event

    But in perl isn't it named "process_event"? Can't we use the same
    convention in the python case?

    > header, attribute, perf_sample, raw_data in format of raw string. And
    > the python script can use "struct" module's unpack function to disasemble
    > the needed info and process.
    >
    > Signed-off-by: Feng Tang <feng.tang@intel.com>
    > ---
    > .../util/scripting-engines/trace-event-python.c | 60 +++++++++++++++++++-
    > 1 files changed, 59 insertions(+), 1 deletions(-)
    >
    > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c
    > index c2623c6..aaf2679 100644
    > --- a/tools/perf/util/scripting-engines/trace-event-python.c
    > +++ b/tools/perf/util/scripting-engines/trace-event-python.c
    > @@ -324,6 +325,63 @@ static void python_process_event(union perf_event *pevent __unused,
    > Py_DECREF(t);
    > }
    >
    > +static void python_process_general_event(union perf_event *pevent __unused,
    > + struct perf_sample *sample,
    > + struct perf_evsel *evsel __unused,
    > + struct machine *machine __unused,
    > + struct thread *thread __unused)
    > +{
    > + PyObject *handler, *retval, *t;
    > + static char handler_name[64];
    > + unsigned n = 0;
    > + void *data = sample->raw_data;
    > +
    > + t = PyTuple_New(MAX_FIELDS);
    > + if (!t)
    > + Py_FatalError("couldn't create Python tuple");
    > +
    > + sprintf(handler_name, "process_general_event");

    Strange use of sprintf, if you think it is safe to not bounds check, use
    strcpy(), if you still want to use sprintf, please instead use:

    snprintf(handler_name, sizeof(handler_name), "%s", "process_event");

    > + handler = PyDict_GetItemString(main_dict, handler_name);
    > + if (handler && !PyCallable_Check(handler)) {
    > + handler = NULL;
    > + goto exit;
    > + }
    > +
    > + /* Pass 3 parameters: event_attr, perf_sample, raw data */
    > + PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
    > + (const char *)&evsel->attr, sizeof(evsel->attr)));
    > + PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
    > + (const char *)sample, sizeof(*sample)));
    > + PyTuple_SetItem(t, n++, PyString_FromStringAndSize(
    > + data, sample->raw_size));
    > +
    > + if (_PyTuple_Resize(&t, n) == -1)
    > + Py_FatalError("error resizing Python tuple");
    > +
    > + retval = PyObject_CallObject(handler, t);
    > + if (retval == NULL)
    > + handler_call_die(handler_name);
    > +exit:
    > + Py_DECREF(t);
    > +}
    > +
    > +static void python_process_event(union perf_event *pevent,
    > + struct perf_sample *sample,
    > + struct perf_evsel *evsel,
    > + struct machine *machine,
    > + struct thread *thread)
    > +{
    > + switch (evsel->attr.type) {
    > + case PERF_TYPE_TRACEPOINT:
    > + python_process_tracepoint(pevent, sample, evsel, machine, thread);
    > + break;
    > + /* Reserve for future process_hw/sw/raw APIs */
    > + default:
    > + python_process_general_event(pevent, sample, evsel, machine, thread);
    > + }
    > +}
    > +
    > static int run_start_sub(void)
    > {
    > PyObject *handler, *retval;
    > --
    > 1.7.1


    \
     
     \ /
      Last update: 2012-05-17 18:21    [W:0.031 / U:3.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site