lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC] printk: add relative printk timing support
    On Thu, May 17, 2012 at 5:02 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
    > This patch adds support for relative timestamps in printk output.

    >  static size_t print_prefix(const struct log *msg, bool syslog, char *buf)

    > +       } else if (printk_time == 2 || printk_time == 3) {
    > +               static unsigned long long last_print;

    We can have multiple concurrent users of the relative time calculation, right?

    I guess the last_print needs to be localized to every possible user
    and concurrent instance: syslog(dmesg), syslog(/proc/kmsg), console
    output, to not race against each other?

    Kay
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-17 18:21    [W:0.024 / U:2.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site