lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] floppy: convert to delayed work and single-thread wq
On Thu, May 17, 2012 at 05:06:41PM +0200, Jiri Kosina wrote:
> On Thu, 17 May 2012, Tejun Heo wrote:
>
> > > Umm. If there are abritrarily long things and these are serialized,
> > > then that workqueue is not good for putting floppy work on it either,
> > > is it? I don't think you can have it both ways.
> >
> > They're not being serialized.
>
> Then it's useless for this very purpose -- the sole purpose of the
> floppy_wq having as a single-threaded wq is to run all the work
> serialized.
>
> So the patch I have sent out this morning is the way to go.

Yeah, that seems to be my confusion here - I thought serialization is
necessary only for a work item. Can you please use
alloc_ordered_workqueue() instead of create_singlethread_workqueue()?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-05-17 18:21    [from the cache]
©2003-2011 Jasper Spaans