lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 3/3] x86: Support local_flush_tlb_kernel_range
    From
    Date
    On Thu, 2012-05-17 at 17:11 +0900, Minchan Kim wrote:
    > > +++ b/arch/x86/include/asm/tlbflush.h
    > > @@ -172,4 +172,16 @@ static inline void flush_tlb_kernel_range(unsigned long start,
    > > flush_tlb_all();
    > > }
    > >
    > > +static inline void local_flush_tlb_kernel_range(unsigned long start,
    > > + unsigned long end)
    > > +{
    > > + if (cpu_has_invlpg) {
    > > + while (start < end) {
    > > + __flush_tlb_single(start);
    > > + start += PAGE_SIZE;
    > > + }
    > > + } else
    > > + local_flush_tlb();
    > > +}


    It would be much better if you wait for Alex Shi's patch to mature.
    doing the invlpg thing for ranges is not an unconditional win.

    Also, does it even work if the range happens to be backed by huge pages?
    IIRC we try and do the identity map with large pages wherever possible.


    \
     
     \ /
      Last update: 2012-05-17 17:41    [W:4.044 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site