lkml.org 
[lkml]   [2012]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] staging: comedi: Convert struct addi_board initialization to C99 format
Wednesday, May 16, 2012 7:18 PM, Greg KH wrote:
> On Wed, May 16, 2012 at 05:51:56PM -0700, H Hartley Sweeten wrote:
>> Convert the struct addi_board initialization to C99 format and remove
>> all the NULL or 0 initializers. This makes maintaining and editing the
>> code simpler and less error prone.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Ian Abbott <abbotti@mev.co.uk>
>> Cc: Mori Hess <fmhess@users.sourceforge.net>
>>
>> ---
>>
>> This patch is a bit large but should be easy enough to review.
>> It does incease the size of the source file in bytes but it reduces
>> the lines of code by 1103 lines.
>>
>> There are 6 checkpatch warnings about lines over 80 characters
>> due to the long CamelCase names for some of the functions.
>> "Fixing" these actually hurts the readability of the code. The
>> checkpatch warnings will be addressed later by renaming the
>> CamelCase functions.
>
> Nice job, this driver is a pain to read...

Thanks. I agree... I've been avoiding the addi drivers until now.
Anytime a C file has an #include "something.c" it makes me
shudder...

I've been thinking that the addi stuff should really be broken up
into some library modules with exported symbols for the individual
addi drivers to use. I need to look a bit closer at them to see if
this would work. Right now the whole thing is a bit of a mess.

Regards,
Hartley


Regards,
Hartley

\
 
 \ /
  Last update: 2012-05-17 08:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site