[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/6] pstore/ram: Add some more documentation and examples
On Wed, May 16, 2012 at 3:11 PM, Anton Vorontsov <> wrote:
> On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote:
> [...]
>> > +You can specify either RAM memory or peripheral devices' memory. However, when
>> > +specifying RAM, be sure to reserve the memory by issuing memblock_reserve()
>> > +very early in the architecture code, just before platform device registration,
>> Just before platform device registration is way too late.  ARM
>> provides a machine reserve callback to allow board files to call
>> memblock_reserve inside arm_memblock_init() and before mm_init().
> Yeah, and I guess that 'too late' is also true for all architectures,
> the platform_device_register and friends are most probably unusable
> before mm_init, and after that it's always too late.
> So the word 'just' is misleading indeed, I'll remove it.

I think any reference to the time when platform devices are registered
is misleading. There is a very specific point during arch init where
memblock_reserve is valid, and it is nowhere near platform device
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-05-17 00:41    [W:0.135 / U:31.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site