[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] floppy: convert to delayed work and single-thread wq
    On Wed, May 16, 2012 at 10:24:37PM +0200, Jiri Kosina wrote:
    > In floppy_grab_irq_and_dma() the point is to drain the workqueue
    > completely (before the conversion, we were just using
    > flush_work_sync(&floppy_work) for particular work item), and for that
    > flush_work() is not sufficient any more.
    > So I am really considering going back to driver-specific singlethreaded
    > workqueue.

    Ummm... still confused. flush_work_sync() is fine too. If you have
    two, two calls to flush_work_sync() are equivalent to flushing the
    workqueue in effect. You just need to avoid flush_workqueue() because
    system workqueues may be hosting work items which can run arbitrarily



     \ /
      Last update: 2012-05-16 23:21    [W:0.030 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site