lkml.org 
[lkml]   [2012]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] [RFC] UBI: Export next_sqnum()
    Hi Richard,

    On Tue, 15 May 2012 19:11:05 +0200 Richard Weinberger <richard@nod.at> wrote:
    > The fastmap mechanism needs to read the next sequence nummber
    > directly.
    >
    > Signed-off-by: Richard Weinberger <richard@nod.at>
    > ---
    > drivers/mtd/ubi/eba.c | 18 +++++++++---------
    > drivers/mtd/ubi/ubi.h | 1 +
    > 2 files changed, 10 insertions(+), 9 deletions(-)
    >
    > diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c
    > index bd5fdbf..d75677d 100644
    > --- a/drivers/mtd/ubi/eba.c
    > +++ b/drivers/mtd/ubi/eba.c
    > @@ -57,7 +57,7 @@
    > * global sequence counter value. It also increases the global sequence
    > * counter.
    > */
    > -static unsigned long long next_sqnum(struct ubi_device *ubi)
    > +unsigned long long ubi_next_sqnum(struct ubi_device *ubi)

    Minor nit.

    Comment above the function should have been changed too.
    (look for the "next_sqnum - get next sequence number" comment)

    Other than that,
    Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>

    Regards,
    Shmulik


    \
     
     \ /
      Last update: 2012-05-16 16:41    [W:0.023 / U:34.260 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site