[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[34-longterm 112/179] SUNRPC: Fix use of static variable in rpcb_getport_async
    From: Ben Greear <>

    This is a commit scheduled for the next v2.6.34 longterm release.
    If you see a problem with using this for longterm, please comment.

    commit ec0dd267bf7d08cb30e321e45a75fd40edd7e528 upstream.

    Because struct rpcbind_args *map was declared static, if two
    threads entered this method at the same time, the values
    assigned to map could be sent two two differen tasks.
    This could cause all sorts of problems, include use-after-free
    and double-free of memory.

    Fix this by removing the static declaration so that the map
    pointer is on the stack.

    Signed-off-by: Ben Greear <>
    Signed-off-by: Trond Myklebust <>
    Signed-off-by: Paul Gortmaker <>
    net/sunrpc/rpcb_clnt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
    index 1211053..ab39ae2 100644
    --- a/net/sunrpc/rpcb_clnt.c
    +++ b/net/sunrpc/rpcb_clnt.c
    @@ -580,7 +580,7 @@ void rpcb_getport_async(struct rpc_task *task)
    u32 bind_version;
    struct rpc_xprt *xprt;
    struct rpc_clnt *rpcb_clnt;
    - static struct rpcbind_args *map;
    + struct rpcbind_args *map;
    struct rpc_task *child;
    struct sockaddr_storage addr;
    struct sockaddr *sap = (struct sockaddr *)&addr;

     \ /
      Last update: 2012-05-15 09:41    [W:3.700 / U:1.268 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site