Messages in this thread | | | Date | Mon, 14 May 2012 16:48:11 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH 2/2] mfd: anatop: permit adata be NULL when access register |
| |
On Mon, May 14, 2012 at 09:08:36AM +0100, Mark Brown wrote: > On Mon, May 14, 2012 at 11:51:38AM +0800, Shawn Guo wrote: > > > From what I see, it's reasonable. Then the immediate question I have > > is, should we remove "struct anatop *adata" from anatop_read_reg and > > anatop_write_reg completely? > > Given the way these things tend to go it's probably guaranteeing that > your next round of SoCs will have two register compatible anatop blocks :)
Considering anatop block tends to be a container of misc hardware control bits, I haven't really seen any possibility that the future SoCs will have multiple anatop blocks.
-- Regards, Shawn
| |