Messages in this thread |  | | | From | Namhyung Kim <> | | Subject | Re: [PATCH] perf-record: Create events initially disabled -- again | | Date | Tue, 15 May 2012 10:54:21 +0900 |
| |
Hi,
On Mon, 14 May 2012 22:46:33 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, May 14, 2012 at 07:42:30PM -0600, David Ahern escreveu: >> On 5/14/12 7:07 PM, Namhyung Kim wrote: >> >>Something else is wrong then. I tested that command (saw your patch in >> >>the history) and it worked for me. Also, this code path does not >> >>affect perf-stat -- it touches perf-record and perf-test only. > >> >Ah, right. But still wouldn't it be better changing the conditional >> >rather than disabling it unconditionally? > >> I think it would be best to disable all events initially and then >> enable them when ready. It works for perf-record and perf-test just >> fine and limits the samples to what you care about. > > And we need to have all this logic in a central place, the "open" method > of perf_evlist :-) >
Agreed. So we need to make it generic to suitable for perf-stat and perf-top (and others?) also.
> The perf_target abstraction is the way to get there, but in the process > I think we really need to have each new method with a 'perf test' entry > and in addition to that an 'autotest'* entry to test the perf builtins. > > - Arnaldo > > * http://autotest.github.com/
I'll have a look at it.
Thanks, Namhyung
|  |