Messages in this thread | | | From | Sasha Levin <> | Date | Mon, 14 May 2012 23:39:09 +0200 | Subject | Re: [PATCH] net: codel: fix build errors |
| |
On Mon, May 14, 2012 at 11:08 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Anonymous unions are fine, we use them a lot in kernel.
While we use them a lot, we don't try initializing them that often.
> Please fix the initializers instead in fq_codel_dump_stats(), because > these two #define are not very nice.
The only method I know of fixing that up is getting braces around them in the initializer, which is hacky and will break every time a new member is added to the struct before the anonymous union. Is there a different solution?
| |