[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH V3 2/2] gpio: add STA2X11 GPIO block
    Hello Grant. Sorry for the delay.

    >> + /* 384 was used in previous code: be compatible for other drivers */
    >> + err = irq_alloc_descs(-1, 384, GSTA_NR_GPIO, NUMA_NO_NODE);

    > Where does the number 384 come from? It looks like the driver only
    > needs to allocate a range of irqs and that it doesn't actually matter
    > what the real numbers are. Can 0 be used instead?

    The problem is that there are a number of drivers already working (but
    not ready to be upstreamed), and we'd better continue using them. So,
    the mmc driver is requesting a specific interrupt number. The code is
    GPL (published on sourceforge) and I'd better remain compatible.

    I'm not completely clear (yet) about how to get the right interrupt
    number in those other drivers, but I'm willing to remove the constraint
    as they are cleaned up and submitted.

    > Actually, I'd rather see this driver switched to using
    > irq_domain_add_linear so that irq_descs can be allocated on demand
    > instead of all at once. That way only gpios actually used for irqs
    > get setup.

    If it is a request, I'll evaluate it soon. I assume an incremental
    patch over what Samuel has already picked up is fine.


     \ /
      Last update: 2012-05-14 10:22    [W:0.031 / U:6.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site