lkml.org 
[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/5] pinctrl: a minor error checking improvement for pinconf
    Date
    From: Dong Aisheng <dong.aisheng@linaro.org>

    Also checking invalid num_configs when validate the pinconf map.

    Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
    ---
    drivers/pinctrl/pinconf.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
    index 7ce139e..43f474c 100644
    --- a/drivers/pinctrl/pinconf.c
    +++ b/drivers/pinctrl/pinconf.c
    @@ -50,9 +50,9 @@ int pinconf_validate_map(struct pinctrl_map const *map, int i)
    return -EINVAL;
    }

    - if (map->data.configs.num_configs &&
    + if (!map->data.configs.num_configs ||
    !map->data.configs.configs) {
    - pr_err("failed to register map %s (%d): no configs ptr given\n",
    + pr_err("failed to register map %s (%d): no configs given\n",
    map->name, i);
    return -EINVAL;
    }
    --
    1.7.0.4



    \
     
     \ /
      Last update: 2012-05-14 14:01    [W:0.025 / U:62.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site