[lkml]   [2012]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/7] mmc: dw_mmc: add device tree support
    Hi Thomas

    On Sat, 12 May 2012, Thomas Abraham wrote:

    > On 4 May 2012 04:18, Guennadi Liakhovetski <> wrote:
    > >
    > > What do you think about this patch
    > >
    > >
    > >
    > > and about using mmc-generic OF properties instead of creating yet another
    > > copy of proprietary ones?
    > Hi Guennadi,
    > This patch does not intend to add any custom mmc properties. I checked
    > your patch (in the link mentioned above) and most of the bindings are
    > similar to what you have come up with except for the "ro-gpios" for
    > which I have used "wp-gpios". But this is following what Arnd had
    > proposed here:

    Thanks for the link! I didn't know about that patch.

    > Regarding the MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA in your patch,
    > these can be derived from the bus width information that the driver
    > receives.

    Sure. I think, my patch, that I mentioned above, shall be dropped, at
    least in its present form. But if at least in principle we do want to have
    a common MMC OF parser for common bindings, some code from your patch
    would become redundant, I think. BTW, isn't this

    + gpio = of_get_named_gpio(np, "wp_gpios", 0);

    a typo? Shouldn't it be "wp-gpios" instead?

    Guennadi Liakhovetski, Ph.D.
    Freelance Open-Source Software Developer

     \ /
      Last update: 2012-05-12 22:21    [W:0.024 / U:15.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site