Messages in this thread | | | Subject | Re: [PATCH v4 5/7] x86/tlb: add tlb flush all factor for specific CPU | From | Peter Zijlstra <> | Date | Thu, 10 May 2012 11:38:35 +0200 |
| |
On Thu, 2012-05-10 at 13:00 +0800, Alex Shi wrote:
> +void intel_tlb_flushall_factor_set(struct cpuinfo_x86 *c) > +{ > + if (!cpu_has_invlpg) { > + tlb_flushall_factor = -1; > + return; > + }
...
> + if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB > + || tlb_flushall_factor == (u16)TLB_FLUSH_ALL) > { > flush_all:
Since you set tlb_flushall_factor (I'd have called it _shift) to -1 when !invlpg there's a redundant check in there.
| |