Messages in this thread | | | Date | Fri, 11 May 2012 08:59:14 +0800 | From | Alex Shi <> | Subject | Re: [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user testing/tuning |
| |
> Nowhere do you say this is x86 only, please fix that.
sure.
> > Yeah, another tunable that no one knows how to use. > > Really, why is this here at all? As others pointed out, this really > looks like a debugging thing that almost no one will ever need, so > please, put it in debugfs.
Ok.
> > > Do the #ifdef in the .h file, not the .c file please, no matter how you > end up doing this (debugfs vs. sysfs.)
Ok.
> > thanks, > > greg k-h >
| |