[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] staging: android: logger: Allocate logs dynamically at boot (v2)
    On 05/10/2012 02:21 PM, Greg KH wrote:
    > On Thu, May 10, 2012 at 02:16:31PM -0700, Tim Bird wrote:
    >> + log->misc.minor = MISC_DYNAMIC_MINOR;
    >> + log-> = kstrdup(log_name, GFP_KERNEL);
    >> + if (log-> == NULL) {
    >> + ret = -1;
    >> + goto out_free_log;
    > Please return a "real" error number, not just -1. You do this a few
    > times in this function, -EINVAL perhaps? -1 is -EPERM, which is not
    > what you want to be saying here, right?

    You're right. This is only called by init code now, which doesn't
    look at the return value (only checks for non-zero), but the intent
    is to change this going forward, so a real error number is called for.

    These are all memory allocation failures, so I'm thinking of using
    -ENOMEM. Would that be right?
    -- Tim

    Tim Bird
    Architecture Group Chair, CE Workgroup of the Linux Foundation
    Senior Staff Engineer, Sony Network Entertainment

     \ /
      Last update: 2012-05-11 00:01    [W:0.024 / U:1.940 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site