Messages in this thread | | | Date | Thu, 10 May 2012 14:21:22 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/2] staging: android: logger: Allocate logs dynamically at boot (v2) |
| |
On Thu, May 10, 2012 at 02:16:31PM -0700, Tim Bird wrote: > + log->misc.minor = MISC_DYNAMIC_MINOR; > + log->misc.name = kstrdup(log_name, GFP_KERNEL); > + if (log->misc.name == NULL) { > + ret = -1; > + goto out_free_log;
Please return a "real" error number, not just -1. You do this a few times in this function, -EINVAL perhaps? -1 is -EPERM, which is not what you want to be saying here, right?
thanks,
greg k-h
| |