lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 45/52] sony-laptop: Enable keyboard backlight by default
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Josh Boyer <jwboyer@redhat.com>

    commit 6fe6ae56a7cebaebc2e6daa11c423e4692f9b592 upstream.

    When the keyboard backlight support was originally added, the commit said
    to default it to on with a 10 second timeout. That actually wasn't the
    case, as the default value is commented out for the kbd_backlight parameter.
    Because it is a static variable, it gets set to 0 by default without some
    other form of initialization.

    However, it seems the function to set the value wasn't actually called
    immediately, so whatever state the keyboard was in initially would remain.
    Then commit df410d522410e67660 was introduced during the 2.6.39 timeframe to
    immediately set whatever value was present (as well as attempt to
    restore/reset the state on module removal or resume). That seems to have
    now forced the light off immediately when the module is loaded unless
    the option kbd_backlight=1 is specified.

    Let's enable it by default again (for the first time). This should solve
    https://bugzilla.redhat.com/show_bug.cgi?id=728478

    Signed-off-by: Josh Boyer <jwboyer@redhat.com>
    Acked-by: Mattia Dongili <malattia@linux.it>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Cc: maximilian attems <max@stro.at>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/x86/sony-laptop.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/platform/x86/sony-laptop.c
    +++ b/drivers/platform/x86/sony-laptop.c
    @@ -127,7 +127,7 @@ MODULE_PARM_DESC(minor,
    "default is -1 (automatic)");
    #endif

    -static int kbd_backlight; /* = 1 */
    +static int kbd_backlight = 1;
    module_param(kbd_backlight, int, 0444);
    MODULE_PARM_DESC(kbd_backlight,
    "set this to 0 to disable keyboard backlight, "



    \
     
     \ /
      Last update: 2012-05-10 20:21    [W:0.022 / U:9.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site