lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/3] drivers/net: Convert compare_ether_addr to ether_addr_equal
    From
    From: Joe Perches <joe@perches.com>
    Date: Thu, 10 May 2012 09:11:28 -0700

    > (cc's trimmed)
    >
    > On Thu, 2012-05-10 at 17:32 +0300, Jussi Kivilinna wrote:
    >> Quoting Joe Perches <joe@perches.com>:
    >> > Use the new bool function ether_addr_equal to add
    >> > some clarity and reduce the likelihood for misuse
    >> > of compare_ether_addr for sorting.
    > []
    >> > diff --git a/drivers/net/wireless/rndis_wlan.c
    > []
    >> > @@ -2139,7 +2139,7 @@ resize_buf:
    >> > while (check_bssid_list_item(bssid, bssid_len, buf, len)) {
    >> > if (rndis_bss_info_update(usbdev, bssid) && match_bssid &&
    >> > matched) {
    >> > - if (compare_ether_addr(bssid->mac, match_bssid))
    >> > + if (!ether_addr_equal(bssid->mac, match_bssid))
    >>
    >> While reviewing this, noticed that above original code is wrong. It
    >> should be !compare_ether_addr. So do I push patch fixing this through
    >> wireless-testing althought it will later cause conflict with this patch?
    >>
    >> -Jussi
    >>
    >> > *matched = true;
    >> > }
    >> >
    >
    > Up to John.
    >
    > Here's the patch I would send against net-next
    > updating the test and the style a little.

    I think in this specific case it's better to push this one directly
    through net-next. But yes, it's up to John.



    \
     
     \ /
      Last update: 2012-05-10 19:01    [W:0.033 / U:29.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site