lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks
On Wed, May 02, 2012 at 03:53:53PM +0100, James Hogan wrote:
> Hi
>
> On 2 May 2012 06:07, Thomas Abraham <thomas.abraham@linaro.org> wrote:
> > +       if (IS_ERR(host->biu_clk))
> > +               dev_info(&host->dev, "biu clock not available\n");
>
> In this case, should it set host->biu_clk to NULL or are clk_disable
> and clk_put guaranteed to handle an IS_ERR value?

I keep saying this. NULL must be treated as a valid reutrn value from
clk_get() and must not use this as a sentinel. The clk namespace is
that errors are indicated with IS_ERR(clk) returning true. Everything
else must be assumed to be valid by drivers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-05-10 16:21    [W:0.149 / U:22.160 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site