lkml.org 
[lkml]   [2012]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched: set TAINT_UNSAFE_SMP after sleep-in-atomic bug
From
Date
On Thu, 2012-05-10 at 14:56 +0400, Konstantin Khlebnikov wrote:
> Peter Zijlstra wrote:
> > On Thu, 2012-05-10 at 11:54 +0400, Konstantin Khlebnikov wrote:
> >> Usually sleep-in-atomic bugs are followed by dozens other warnings.
> >> This patch should help to figure out original source of problem.
> >> This taint flag also turns off lockdep, because it can go mad after that.
> >
> > There's already TAINT_WARN any output with that set should be ignored.
>
> Where? I do not see here anything which might set TAINT_WARN.
>
> Or you suggest to use TAINT_WARN instead of TAINT_UNSAFE_SMP?

Gargh, yeah it doesn't use WARN and related infrastructure to print that
msg so it missed out on the whole TAINT_WARN stuff.

Yeah, make it set TAINT_WARN or possibly convert the thing to use WARN.



\
 
 \ /
  Last update: 2012-05-10 14:41    [from the cache]
©2003-2011 Jasper Spaans