lkml.org 
[lkml]   [2012]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] hugetlb: avoid gratuitous BUG_ON in hugetlb_fault() -> hugetlb_cow()
    On Sun, Apr 29, 2012 at 03:04:51PM -0400, Chris Metcalf wrote:
    > Commit 66aebce747eaf added code to avoid a race condition by
    > elevating the page refcount in hugetlb_fault() while calling
    > hugetlb_cow(). However, one code path in hugetlb_cow() includes
    > an assertion that the page count is 1, whereas it may now also
    > have the value 2 in this path. Consensus is that this BUG_ON
    > has served its purpose, so rather than extending it to cover both
    > cases, we just remove it.
    >
    > Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

    Acked-by: Mel Gorman <mel@csn.ul.ie>

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2012-05-01 16:21    [W:0.023 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site