lkml.org 
[lkml]   [2012]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] net/key/af_key.c: add missing kfree_skb
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    At the point of this error-handling code, alloc_skb has succeded, so free
    the resulting skb by jumping to the err label.

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    net/key/af_key.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/key/af_key.c b/net/key/af_key.c
    index 11dbb22..7e5d927 100644
    --- a/net/key/af_key.c
    +++ b/net/key/af_key.c
    @@ -3480,7 +3480,7 @@ static int pfkey_send_migrate(const struct xfrm_selector *sel, u8 dir, u8 type,

    /* Addresses to be used by KM for negotiation, if ext is available */
    if (k != NULL && (set_sadb_kmaddress(skb, k) < 0))
    - return -EINVAL;
    + goto err;

    /* selector src */
    set_sadb_address(skb, sasize_sel, SADB_EXT_ADDRESS_SRC, sel);


    \
     
     \ /
      Last update: 2012-04-09 10:43    [W:0.024 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site