Messages in this thread Patch in this message | | | Date | Mon, 9 Apr 2012 22:50:36 +0200 (CEST) | From | Jesper Juhl <> | Subject | [PATCH 08/26] qlogic, qlcnic: get rid of redundant test for NULL before a call to release_firmware() |
| |
Since release_firmware() deals gracefully with being passed a NULL pointer there's no reason to test explicitly before calling the function.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c index d32cf0d..799fd40 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c @@ -1321,8 +1321,7 @@ next: void qlcnic_release_firmware(struct qlcnic_adapter *adapter) { - if (adapter->fw) - release_firmware(adapter->fw); + release_firmware(adapter->fw); adapter->fw = NULL; } -- 1.7.10
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |