Messages in this thread |  | | | From | Grant Likely <> | | Subject | Re: [PATCH 2/2] gpiolib: Implement devm_gpio_request_one() | | Date | Fri, 06 Apr 2012 19:25:12 -0700 |
| |
On Fri, 6 Apr 2012 15:49:17 +0100, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Thu, Apr 05, 2012 at 09:48:32PM -0700, Grant Likely wrote: > > > Can we make devm_gpio_request a static inline wrapper around > > devm_gpio_request_one() with the flags field set to '0'? I don't liek > > the duplication of this function. > > > Similarily, gpio_request() should actually be a static inline around > > gpio_request_one() instead of the other way around as it is currently > > written. > > Yeah, I couldn't understand why the non-managed functions were written > in this way so I followed the same pattern when I added the managed one > assuming that the original code was sane.
Actually, I looked at it again, and the _one version behaves subtly different from the non-_one version. That may be irrelevant though. g.
-- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd.
|  |