lkml.org 
[lkml]   [2012]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] printk: support structured and multi-facility log messages
From
Date
(grumble, evolution is a stupid email client, resending)

On Fri, 2012-04-06 at 20:35 +0200, Kay Sievers wrote:
> On Thu, 2012-04-05 at 18:31 -0700, Linus Torvalds wrote:
> > On Thu, Apr 5, 2012 at 6:12 PM, Joe Perches <joe@perches.com> wrote:
> > >
> > > I still think this should be 3 patches not 1.
> >
> > I do agree that that would be lovely. That patch is really hard to
> > read, and it would be helpful if some of it was split up a bit. For
> > example, separating out the "move log buffer to be packetized"
> > (without actually doing the new things) from for the "introduce new
> > interfaces" would be quite nice.
> >
> > In fact, I think I could merge something that does the packetization
> > early, if it is fairly obvious that it doesn't do anything else. Just
> > making the dmesg ASCII timestamp be something that is a "read buffer"
> > time thing rather than "generate printk" time thing would be nice, and
> > I think the sequence numbers can be useful even with all the old
> > interfaces.
> >
> > So if somebody wants to help with things like that, and try to turn
> > this into a more gradual thing, I think we could merge at least some
> > initial parts of this patch even for 3.4.
>
> Here is only the conversion of the byte- to the record-buffer split out
> of the big patch.
>
> Unfortunately, it's still pretty big, and the patch not easy to read;
> the code itself looks better than the patch. At this moment I have no
> convincing idea how to split that into more pieces.

I'll spend some time on breaking up Kay's
patch in the next couple of weeks.

I'll try to get my printk restructuring patch
out by Monday.

I think Kay's still relatively large patch can
be broken into a smaller sequence of:

1. Make log_buf ascii "record" oriented
2. Add struct for timestamp/sequence and
integrate it into log_buf with syslog_print
3. Add printk_emit and key/value support
into log_buf

After that, I'll try adding lzo compression to
the message bits and see if that is any benefit.

After Monday, I'll be effectively unavailable
for a few weeks though.



\
 
 \ /
  Last update: 2012-04-08 03:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site