[lkml]   [2012]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN
    On Sat, Apr 7, 2012 at 10:32 PM, Olof Johansson <> wrote:
    > On Sat, Apr 7, 2012 at 11:38 AM, Sven Neumann <> wrote:
    >> Hi,
    >> On 07.04.12 09:02, Dmitry Torokhov wrote:
    >>> On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olof Johansson wrote:
    >>>> This seems to have been broken since 2010, so obviously noone actually
    >>>> cares about the driver:
    >>>> make[4]: *** [drivers/input/touchscreen/eeti_ts.o] Error 1
    >>>> drivers/input/touchscreen/eeti_ts.c: In function 'eeti_ts_irq_active':
    >>>> drivers/input/touchscreen/eeti_ts.c:65:2: error: implicit declaration of
    >>>> function 'irq_to_gpio' [-Werror=implicit-function-declaration]
    >>>> irq_to_gpio isn't available on most platforms today, so the driver
    >>>> will need some rework by someone who has hardware access and can test
    >>>> (to make sure that, for example, switching to level interrupts and just
    >>>> keep taking them while there's more to process works).
    >>>> I guess it could just be scheduled for removal, but let's start with
    >>>> marking it CONFIG_BROKEN.
    >>> Well, it probably works quite well on arches that do have irq_to_gpio(),
    >>> let's ask Daniel and Sven if they still have this hardware and if they
    >>> can try the patch below that implements what you suggested.
    >> This hardware is still in use and we also still follow kernel development
    >> and try to update our customer devices to recent kernel versions regularly.
    >> Currently we are at 3.1.10 and the touchscreen works well with that. I'll
    >> try to update to a more recent kernel next week and will try your patch.
    > Ah, you're right, and this was my bad. Looks like this change was
    > introduced in 3.2 and broke this and one more driver (ezx-pcap):
    > Author:     Haojian Zhuang <>
    > AuthorDate: Mon Oct 10 16:03:51 2011 +0800
    > Commit:     Haojian Zhuang <>
    > CommitDate: Mon Nov 14 21:07:59 2011 +0800
    >    ARM: pxa: rename gpio_to_irq and irq_to_gpio
    >    Avoid to define gpio_to_irq() and irq_to_gpio() for potential name
    >    confliction since multiple architecture will be built together.
    >    Signed-off-by: Haojian Zhuang <>
    > Haojian, I think it was probably premature to do the multiplatform
    > change like that, since it means that a PXA-only kernel has no mapping
    > from irq_to_gpio to pxa_irq_to_gpio. Can you please address this as a
    > fix for 3.4?
    > Thanks,
    > -Olof

    It's the same story with AT91. Here irq_to_gpio was also removed some
    time ago. I believe it's the same for a lot of other ARM architectures
    Currently there 7 drivers that uses irq_to_gpio, these are obviously
    broken on architectures that not provide the function.

    I think it would be better to fix the drivers rather than resurrect
    irq_to_gpio on the individual architectures.

    Users of irq_to_gpio in drivers:
    pata_rb532_cf, eeti_ts, egalax_ts, ezx-pcap, db1xxx_ss, tosa_battery, lis3l02dq

    Joachim Eastwood

    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to
    > More majordomo info at
    > Please read the FAQ at
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-04-07 23:09    [W:0.026 / U:32.096 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site