lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data
    Date
    On Wed, 4 Apr 2012 15:51:38 +0200, "Cousson, Benoit" <b-cousson@ti.com> wrote:
    > On 4/4/2012 3:30 PM, Sourav Poddar wrote:
    > > This patch add keypad data node in omap4 device tree
    > > file.
    >
    > Nit #2: Never write "this patch" in a patch changelog... Because at some
    > point it will become a commit in a GIT tree.
    >
    > I think AKPM wrote something on that.

    Whatever. I'm won't *ever* get worked up about something like that if
    the changelog is otherwise well written. What I do want to see is a
    description of what the patch does, why it is needed, and how it was
    tested.

    g.



    \
     
     \ /
      Last update: 2012-04-07 03:55    [W:0.018 / U:30.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site