lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] irq/irq_domain: Quit ignoring error returns from irq_alloc_desc_from().
Date
On Fri, 06 Apr 2012 09:37:49 -0700, David Daney <ddaney.cavm@gmail.com> wrote:
> On 04/05/2012 08:37 PM, Rob Herring wrote:
> > On 04/05/2012 06:52 PM, David Daney wrote:
> >> From: David Daney<david.daney@cavium.com>
> >> @@ -380,14 +381,14 @@ unsigned int irq_create_mapping(struct irq_domain *domain,
> >> hint = hwirq % irq_virq_count;
> >> if (hint == 0)
> >> hint++;
> >> - virq = irq_alloc_desc_from(hint, 0);
> >
> > You are not looking at mainline. hint was removed in later versions, and
> > the referenced commit ids don't exist.
>
> Please look at Linus' tree before making incorrect statements about
> whether or not code exists on the 'mainline'

Rob is indeed mistaken here, but please let's keep things civil. I
did write the patches to remove the hint, but I avoided merging them
because I think they are risky. I wanted to get the core irq_domain
changes in first. The removal of hint will be applied during the next
merge window.

I will take your bug fix and get it pushed up to Linus soon.

g.


\
 
 \ /
  Last update: 2012-04-07 03:55    [from the cache]
©2003-2011 Jasper Spaans