lkml.org 
[lkml]   [2012]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 1/2] net: In unregister_netdevice_notifier unregister the netdevices.
    From a51fda849355b2ffb27cdb5d66fa1a96e7f47335 Mon Sep 17 00:00:00 2001
    From: Eric W. Biederman <ebiederm@xmission.com>
    Date: Sun, 25 Dec 2011 19:39:52 -0800
    Subject:

    We already synthesize events in register_netdevice_notifier and synthesizing
    events in unregister_netdevice_notifier allows to us remove the need for
    special case cleanup code.

    This change should be safe as it adds no new cases for existing callers
    of unregiser_netdevice_notifier to handle.

    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
    ---
    net/core/dev.c | 20 ++++++++++++++++++++
    1 files changed, 20 insertions(+), 0 deletions(-)

    diff --git a/net/core/dev.c b/net/core/dev.c
    index 452db70..77c0a87 100644
    --- a/net/core/dev.c
    +++ b/net/core/dev.c
    @@ -1410,14 +1410,34 @@ EXPORT_SYMBOL(register_netdevice_notifier);
    * register_netdevice_notifier(). The notifier is unlinked into the
    * kernel structures and may then be reused. A negative errno code
    * is returned on a failure.
    + *
    + * After unregistering unregister and down device events are synthesized
    + * for all devices on the device list to the removed notifier to remove
    + * the need for special case cleanup code.
    */

    int unregister_netdevice_notifier(struct notifier_block *nb)
    {
    + struct net_device *dev;
    + struct net *net;
    int err;

    rtnl_lock();
    err = raw_notifier_chain_unregister(&netdev_chain, nb);
    + if (err)
    + goto unlock;
    +
    + for_each_net(net) {
    + for_each_netdev(net, dev) {
    + if (dev->flags & IFF_UP) {
    + nb->notifier_call(nb, NETDEV_GOING_DOWN, dev);
    + nb->notifier_call(nb, NETDEV_DOWN, dev);
    + }
    + nb->notifier_call(nb, NETDEV_UNREGISTER, dev);
    + nb->notifier_call(nb, NETDEV_UNREGISTER_BATCH, dev);
    + }
    + }
    +unlock:
    rtnl_unlock();
    return err;
    }
    --
    1.7.2.5


    \
     
     \ /
      Last update: 2012-04-07 03:31    [W:0.040 / U:90.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site